Skip to content

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Sep 20, 2025

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • Style
    • Header now remains fixed at the top while scrolling.
    • Improved vertical spacing across order pages and lists with added top/bottom margins.
    • Store page adds extra bottom padding when the cart has items for clearer layout.
    • Increased bottom padding in menu lists for better spacing.
    • Sold-out badge text now avoids awkward line breaks for clearer readability.

@coderabbitai
Copy link

coderabbitai bot commented Sep 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Switches BackHeader from sticky to fixed positioning. Adjusts spacing classes across menu and order pages, including dynamic bottom padding on StorePage when the cart has items. Adds top/bottom margins to order-related pages and increases bottom padding in MenuList. Minor text-breaking tweak for sold-out badge.

Changes

Cohort / File(s) Summary
Header positioning
apps/nowait-user/src/components/BackHeader.tsx
Changed header from sticky to fixed by updating class from "sticky left-0 top-0" to "fixed left-0 top-0".
Menu list and item styling
apps/nowait-user/src/components/common/MenuList.tsx, apps/nowait-user/src/components/common/MenuItem.tsx
Increased bottom padding in MenuList from pb-[10px] to pb-[14px]. Added break-keep to sold-out badge in MenuItem.
Order pages spacing/layout
apps/nowait-user/src/pages/order/home/StorePage.tsx, apps/nowait-user/src/pages/order/orderList/OrderListPage.tsx, apps/nowait-user/src/pages/order/remittance/RemittancePage.tsx
StorePage: dynamic pb-[116px] when cart has items. OrderListPage: added mt-[48px] and mb-[116px]. RemittancePage: added mt-[48px] and mb-[116px].

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • dgKim1
  • oriNuguri25

Poem

I hop through views where headers stay,
Fixed above the scroll’s ballet.
Padding puffed, margins align,
Menus tidy, carts recline.
“Sold out” snug in careful keep—
CSS carrots, crisp and neat. 🥕🐇

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73fbc09 and cd06e03.

📒 Files selected for processing (6)
  • apps/nowait-user/src/components/BackHeader.tsx (1 hunks)
  • apps/nowait-user/src/components/common/MenuItem.tsx (1 hunks)
  • apps/nowait-user/src/components/common/MenuList.tsx (1 hunks)
  • apps/nowait-user/src/pages/order/home/StorePage.tsx (1 hunks)
  • apps/nowait-user/src/pages/order/orderList/OrderListPage.tsx (1 hunks)
  • apps/nowait-user/src/pages/order/remittance/RemittancePage.tsx (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hwangdae hwangdae merged commit ae830e2 into main Sep 20, 2025
2 of 3 checks passed
@github-actions github-actions bot requested a review from dgKim1 September 20, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants